feat(cli): add shell completion support by nekomoyi · Pull Request #974 · voidzero-dev/vite-plus

nekomoyi · 2026-03-16T17:51:18Z

Summary

Implements shell completion for the vp CLI.

Changes

Completion scripts for bash, zsh, fish, and PowerShell are generated in ~/.vite-plus/completion/ when running vp env setup, and automatically sourced in the respective env files.

Fixes

Fixed mixed path separators in env files on Windows to use forward slashes consistently for $HOME-relative paths

# Before
__vp_bin="$HOME/.vite-plus\bin"
# After
__vp_bin="$HOME/.vite-plus/bin"

Increased stack size to 8MB to handle deep recursion in clap_complete::generate() which exceeds Windows' default stack size.

Closes #950

netlify · 2026-03-16T17:51:25Z

✅ Deploy Preview for viteplus-preview ready!

Name	Link
🔨 Latest commit	`55918b2`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/69bd176e428ff60008eab295
😎 Deploy Preview	https://deploy-preview-974--viteplus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nekomoyi · 2026-03-17T03:55:35Z

Looking into the CI failure.

fengmk2

@nekomoyi Thanks! I will merge after successful local verification.

.cargo/config.toml

wtto00 · 2026-03-19T03:44:45Z

There is a bug in the __vp_bin path configuration. Please see #1039.

fengmk2 · 2026-03-19T03:47:12Z

@nekomoyi can you rebase and fix conflicts?

…ive paths Fix mixed path separators in env files on Windows - Before: $HOME/.vite-plus\bin (mixed) - After: $HOME/.vite-plus/bin (consistent) Simplify completion generation with loop-based approach

…dows - Increase stack size to 8MB on Windows - Set RUST_MIN_STACK to 8MB in CI test jobs Cargo test default (2MB) are insufficient for deep recursion in clap_complete::generate(). This causes stack overflow when generating shell completion scripts during tests.

nekomoyi · 2026-03-19T10:53:23Z

There is a bug in the __vp_bin path configuration. Please see #1039.

The forward/backward slash path issue in __vp_bin has been addressed in this PR.

# .vite-plus/env
__vp_bin="$HOME/.vite-plus/bin"

# .vite-plus/env.ps1
$__vp_bin = "C:\Users\nekomoyi\.vite-plus\bin"

fengmk2 · 2026-03-19T13:12:58Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 444eabb7bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-19T13:25:25Z

crates/vite_global_cli/src/commands/env/setup.rs

+elif [ -n "$ZSH_VERSION" ] && type compdef >/dev/null 2>&1; then
+    # Zsh shell with completion support
+    __vp_completion="__VP_COMPLETION_ZSH__"
+    if [ -f "$__vp_completion" ]; then
+        . "$__vp_completion"


Defer zsh completion registration until compinit is ready

This only sources _vp when compdef is already defined. In many real .zshrc setups, ~/.vite-plus/env is sourced before compinit runs (for example, before oh-my-zsh.sh), and the zsh docs explicitly place compdef registration after compinit. In that ordering this branch no-ops and nothing retries later, so vp completion never becomes available even though setup succeeded.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-19T13:25:25Z

crates/vite_global_cli/src/commands/env/setup.rs

+# Shell completion for fish
+set -l __vp_completion "__VP_COMPLETION_FISH__"
+if test -f "$__vp_completion"
+    source "$__vp_completion"


Avoid re-adding fish completions every time env.fish is sourced

env.fish now unconditionally re-sources the generated vp.fish script. Fish's complete builtin adds definitions on top of existing ones when called multiple times, and clap_complete's generated fish script does not clear prior entries first, so any common reload flow like source ~/.config/fish/config.fish or source ~/.vite-plus/env.fish will duplicate every vp completion item in the current session.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 444eabb7bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-19T13:25:25Z

crates/vite_global_cli/src/commands/env/setup.rs

+elif [ -n "$ZSH_VERSION" ] && type compdef >/dev/null 2>&1; then
+    # Zsh shell with completion support
+    __vp_completion="__VP_COMPLETION_ZSH__"
+    if [ -f "$__vp_completion" ]; then
+        . "$__vp_completion"


Defer zsh completion registration until compinit is ready

This only sources _vp when compdef is already defined. In many real .zshrc setups, ~/.vite-plus/env is sourced before compinit runs (for example, before oh-my-zsh.sh), and the zsh docs explicitly place compdef registration after compinit. In that ordering this branch no-ops and nothing retries later, so vp completion never becomes available even though setup succeeded.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-19T13:25:26Z

crates/vite_global_cli/src/commands/env/setup.rs

+# Shell completion for fish
+set -l __vp_completion "__VP_COMPLETION_FISH__"
+if test -f "$__vp_completion"
+    source "$__vp_completion"


Avoid re-adding fish completions every time env.fish is sourced

env.fish now unconditionally re-sources the generated vp.fish script. Fish's complete builtin adds definitions on top of existing ones when called multiple times, and clap_complete's generated fish script does not clear prior entries first, so any common reload flow like source ~/.config/fish/config.fish or source ~/.vite-plus/env.fish will duplicate every vp completion item in the current session.

Useful? React with 👍 / 👎.

fengmk2 · 2026-03-19T13:32:54Z

@nekomoyi There is a problem with the automatic suggestions for subcommands, for example, vp build prompts thousands of possibilities.

vp build                                                                                                              
zsh: do you wish to see all 3976 possibilities (1999 lines)?

nekomoyi · 2026-03-19T14:15:03Z

@fengmk2 I tried to reproduce the problem on my side but couldn't replicate it. When I type vp build and press Tab to trigger completion, it only lists the files in the current directory.

fengmk2 self-requested a review March 17, 2026 03:39

nekomoyi marked this pull request as draft March 17, 2026 07:22

nekomoyi marked this pull request as ready for review March 17, 2026 08:32

fengmk2 approved these changes Mar 18, 2026

View reviewed changes

fengmk2 reviewed Mar 18, 2026

View reviewed changes

.cargo/config.toml Show resolved Hide resolved

nekomoyi added 4 commits March 19, 2026 13:14

feat(cli): add shell completion support

4245aa3

test(cli): add tests for shell completion feature

2b7f46f

fix(cli): normalize path separators to forward slashes in $HOME-relat…

5f6a9f8

…ive paths Fix mixed path separators in env files on Windows - Before: $HOME/.vite-plus\bin (mixed) - After: $HOME/.vite-plus/bin (consistent) Simplify completion generation with loop-based approach

nekomoyi force-pushed the feat/cli-completion branch from 0d02ce0 to 9fb37ec Compare March 19, 2026 05:21

Merge branch 'main' into feat/cli-completion

84ad6ae

fengmk2 self-assigned this Mar 19, 2026

Merge branch 'main' into feat/cli-completion

444eabb

fengmk2 linked an issue Mar 19, 2026 that may be closed by this pull request

Add Git Bash (Windows) support to the CLI #1039

Open

4 tasks

chatgpt-codex-connector bot reviewed Mar 19, 2026

View reviewed changes

Merge branch 'main' into feat/cli-completion

641a3a6

Merge branch 'voidzero-dev:main' into feat/cli-completion

55918b2

Conversation

nekomoyi commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Fixes

Uh oh!

netlify bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview ready!

Uh oh!

nekomoyi commented Mar 17, 2026

Uh oh!

fengmk2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wtto00 commented Mar 19, 2026

Uh oh!

fengmk2 commented Mar 19, 2026

Uh oh!

nekomoyi commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fengmk2 commented Mar 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

fengmk2 commented Mar 19, 2026

Uh oh!

nekomoyi commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nekomoyi commented Mar 16, 2026 •

edited

Loading

netlify bot commented Mar 16, 2026 •

edited

Loading

nekomoyi commented Mar 19, 2026 •

edited

Loading