fix(#1041): respect output.cssFilename and output.cssChunkFilename#1151
Merged
alexander-akait merged 1 commit intowebpack:mainfrom Jan 15, 2026
Merged
fix(#1041): respect output.cssFilename and output.cssChunkFilename#1151alexander-akait merged 1 commit intowebpack:mainfrom
output.cssFilename and output.cssChunkFilename#1151alexander-akait merged 1 commit intowebpack:mainfrom
Conversation
alexander-akait
approved these changes
Jan 15, 2026
Member
|
Sorry for delay, I will fix CI later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1041 by implementing #1041 (comment)
What kind of change does this PR introduce?
Moving
filenameandchunkFilenamenormalization intoapply(because only then do we have access to thecompilerobject).Now the precedence is:
Did you add tests for your changes?
Not yet, need help on where to add the test case. I am not familiar with the
testfolder structure here.Does this PR introduce a breaking change?
No, by always preferring passed in
filenameandchunkFilenamethe breaking change could be avoided.If relevant, what needs to be documented once your changes are merged or what have you already documented?
Maybe mention that we will also respect
output.cssFilenameandoutput.cssChunkFilenamein existing options docs.