fix: update redirect logic for URLs ending with '/'#2255
Open
bjohansebas wants to merge 6 commits intonextfrom
Open
fix: update redirect logic for URLs ending with '/'#2255bjohansebas wants to merge 6 commits intonextfrom
bjohansebas wants to merge 6 commits intonextfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #2255 +/- ##
==========================================
+ Coverage 95.67% 95.70% +0.02%
==========================================
Files 13 13
Lines 901 907 +6
Branches 263 267 +4
==========================================
+ Hits 862 868 +6
Misses 39 39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Okay, this took me a bit of time to understand. This is something similar to what send does. After several attempts, it can probably be refactored even more, but this would be the main solution.
The send workflow is: if it detects a trailing slash at the end of pathname ("/") (line of code), then it goes into another code path, where it joins the original pathname and appends the index (line of code which is configurable, just like in this package). When they are joined, if such an index file exists, it continues with the normal workflow, otherwise, it throws an error, similar to what is handled here. The difference is that now, if there is a trailing slash, the index file (which is configurable) is also appended
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
yes!
If relevant, what needs to be documented once your changes are merged or what have you already documented?