Skip to content

[WPB-23644] mopup#5115

Merged
fisx merged 10 commits intodevelopfrom
WPB-23644-mopup
Mar 16, 2026
Merged

[WPB-23644] mopup#5115
fisx merged 10 commits intodevelopfrom
WPB-23644-mopup

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Mar 12, 2026

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@fisx fisx force-pushed the WPB-23644-mopup branch from 809c3c6 to fb8d0cd Compare March 12, 2026 18:37
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 12, 2026
@fisx fisx force-pushed the WPB-23644-mopup branch from fb8d0cd to ab3088c Compare March 16, 2026 12:02
@fisx fisx marked this pull request as ready for review March 16, 2026 12:24
@fisx fisx requested review from a team as code owners March 16, 2026 12:24
@fisx fisx requested a review from Copilot March 16, 2026 12:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs an API “mop-up” around Apps by simplifying the app data model exposed via UserProfile, renaming GetApp to AppInfo, flattening NewApp, and updating server/interpreters plus golden tests to match.

Changes:

  • Replaces GetApp with AppInfo (now only category + description) and updates UserProfile.profileApp accordingly.
  • Flattens NewApp request fields and changes CreatedApp.user to return a UserProfile (including app info).
  • Updates interpreters/stores and golden tests/fixtures (plus cabal deps) to align with the new JSON shapes.

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
libs/wire-subsystems/test/unit/Wire/MockInterpreters/UserStore.hs Removes a local conversion helper (moved to shared module).
libs/wire-subsystems/src/Wire/UserSubsystem/Interpreter.hs Updates app injection to use AppInfo and adjusts related documentation.
libs/wire-subsystems/src/Wire/StoredUser.hs Adds newStoredUserToStoredUser to shared code.
libs/wire-subsystems/src/Wire/AppSubsystem/Interpreter.hs Switches GetApp/GetApps to AppInfo, changes CreatedApp response construction, and ignores unused app metadata.
libs/wire-subsystems/src/Wire/AppSubsystem.hs Updates effect signatures for GetApp/GetApps to return AppInfo.
libs/wire-subsystems/src/Wire/AppStore/Postgres.hs Ignores metadata on reads to avoid migrations while making it effectively unused.
libs/wire-api/wire-api.cabal Adds new golden test module and dependency needed by the new tests.
libs/wire-api/src/Wire/API/User/Auth.hs Adds Eq derivation for SomeUserToken.
libs/wire-api/src/Wire/API/User.hs Refactors app-related API types/schemas (NewApp, AppInfo, PutApp, CreatedApp).
libs/wire-api/test/golden/** Updates and adds golden fixtures for the new app-related JSON shapes.
integration/test/API/Brig.hs Updates app creation request JSON shape in integration helpers.
changelog.d/1-api-changes/WPB-23644-mopup Documents the API changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fisx added 4 commits March 16, 2026 13:37
This also regenerates cassandra schema with a new cassandra version,
therefore lots of meaningless changes.
@fisx fisx merged commit 14b3310 into develop Mar 16, 2026
12 checks passed
@fisx fisx deleted the WPB-23644-mopup branch March 16, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants