Merged
Conversation
(This was never uesd by any clients. Postgres will keep the empty column to avoid migration issues.)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs an API “mop-up” around Apps by simplifying the app data model exposed via UserProfile, renaming GetApp to AppInfo, flattening NewApp, and updating server/interpreters plus golden tests to match.
Changes:
- Replaces
GetAppwithAppInfo(now onlycategory+description) and updatesUserProfile.profileAppaccordingly. - Flattens
NewApprequest fields and changesCreatedApp.userto return aUserProfile(including app info). - Updates interpreters/stores and golden tests/fixtures (plus cabal deps) to align with the new JSON shapes.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/wire-subsystems/test/unit/Wire/MockInterpreters/UserStore.hs | Removes a local conversion helper (moved to shared module). |
| libs/wire-subsystems/src/Wire/UserSubsystem/Interpreter.hs | Updates app injection to use AppInfo and adjusts related documentation. |
| libs/wire-subsystems/src/Wire/StoredUser.hs | Adds newStoredUserToStoredUser to shared code. |
| libs/wire-subsystems/src/Wire/AppSubsystem/Interpreter.hs | Switches GetApp/GetApps to AppInfo, changes CreatedApp response construction, and ignores unused app metadata. |
| libs/wire-subsystems/src/Wire/AppSubsystem.hs | Updates effect signatures for GetApp/GetApps to return AppInfo. |
| libs/wire-subsystems/src/Wire/AppStore/Postgres.hs | Ignores metadata on reads to avoid migrations while making it effectively unused. |
| libs/wire-api/wire-api.cabal | Adds new golden test module and dependency needed by the new tests. |
| libs/wire-api/src/Wire/API/User/Auth.hs | Adds Eq derivation for SomeUserToken. |
| libs/wire-api/src/Wire/API/User.hs | Refactors app-related API types/schemas (NewApp, AppInfo, PutApp, CreatedApp). |
| libs/wire-api/test/golden/** | Updates and adds golden fixtures for the new app-related JSON shapes. |
| integration/test/API/Brig.hs | Updates app creation request JSON shape in integration helpers. |
| changelog.d/1-api-changes/WPB-23644-mopup | Documents the API changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This also regenerates cassandra schema with a new cassandra version, therefore lots of meaningless changes.
blackheaven
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d