Open
Conversation
This way you don't have to set it when attaching the watcher
…e/more-server-options
…e/more-server-options
…e/more-server-options
…e/more-server-options
…-options' into feature/json-watcher
…e/json-watcher # Conflicts: # src/bin/main.rs
…e/http # Conflicts: # src/bin/server.rs # src/watchers/mod.rs
…e/http # Conflicts: # examples/test.eve # src/bin/server.rs
Feature/json watcher
joshuafcole
requested changes
Sep 4, 2017
Contributor
joshuafcole
left a comment
joshuafcole
left a comment
There was a problem hiding this comment.
I haven't really looked through the http stuff yet but there's some work to do first
examples/json-demo.eve
Outdated
| entity? = if eav = [#json/encode/entity] then "entity" | ||
| else "" | ||
| bind | ||
| encode <- [| children: |
Contributor
There was a problem hiding this comment.
no pipe required when merging (you can't change the identity of an existing thing!)
examples/json-demo.eve
Outdated
| encode = [#flatten] | ||
| [#json/encode/flatten record] | ||
| bind | ||
| encode <- [| children: |
libraries/groove/groove.eve
Outdated
| Create a Groove user from the response | ||
|
|
||
| search | ||
| [#groove-profile json-object: profile] |
Contributor
There was a problem hiding this comment.
shouldn't this be #groove/profile?
libraries/groove/groove.eve
Outdated
| end | ||
|
|
||
| search | ||
| [#groove-search query response: [body]] |
libraries/groove/groove.eve
Outdated
| end | ||
|
|
||
| search | ||
| [#groove-get-song track response: [body]] |
libraries/json/json.eve
Outdated
|
|
||
| ### Bring it all together | ||
|
|
||
| Join all encoded avs into a compelte string |
| complete-av = [#json/encode/complete-av record] | ||
| target-record = [#json/encode/record record] | ||
| bind | ||
| [#string/join #json/encode/join-complete record with: ", " | strings: complete-av.json-string] |
Contributor
There was a problem hiding this comment.
we can switch to gather/string-join now
Contributor
Author
There was a problem hiding this comment.
I had some issues getting it to work the way I expected. I think I need a description on the parameters.
| runner.program.attach(Box::new(WebsocketClientWatcher::new(out.clone(), client_name))); | ||
| runner.program.attach(Box::new(ConsoleWatcher::new())); | ||
| runner.program.attach(Box::new(PanicWatcher::new())); | ||
| runner.program.attach(Box::new(JsonWatcher::new(outgoing.clone()))); |
Contributor
There was a problem hiding this comment.
looks like it got added twice?
| pub fn string_encode(params: Vec<&Internable>) -> Option<Internable> { | ||
| match params.as_slice() { | ||
| &[&Internable::String(ref text)] => Some(Internable::String(base64::encode(text.as_bytes()))), | ||
| _ => None |
Contributor
There was a problem hiding this comment.
should probably return numbers as a string of themselves here?
| pub fn string_urlencode(params: Vec<&Internable>) -> Option<Internable> { | ||
| match params.as_slice() { | ||
| &[&Internable::String(ref text)] => Some(Internable::String(urlencoding::encode(text))), | ||
| _ => None |
Contributor
There was a problem hiding this comment.
should probably return numbers as a string of themselves here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.