This repository was archived by the owner on Feb 14, 2025. It is now read-only.
Add documentation on how to block installation based on OS & VCREDIST versions#300
Open
forderud wants to merge 1 commit intowixtoolset:masterfrom
Open
Add documentation on how to block installation based on OS & VCREDIST versions#300forderud wants to merge 1 commit intowixtoolset:masterfrom
forderud wants to merge 1 commit intowixtoolset:masterfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
wixbot
added a commit
to wixtoolset/.github
that referenced
this pull request
Oct 10, 2024
forderud
force-pushed
the
os-vcredist-check
branch
3 times, most recently
from
47e3e38 to
dc68b29
Compare
forderud
force-pushed
the
os-vcredist-check
branch
from
dc68b29 to
9bf4400
Compare
… versions Attempt on addressing wixtoolset/issues#8785 and wixtoolset/issues#8786 by extending the WiX documentation to also cover these to checks that I believe are quite common.
forderud
force-pushed
the
os-vcredist-check
branch
from
9bf4400 to
dfcb1f4
Compare
Author
|
@barnson Would it be possible for you to take a look at this documentation update proposal? |
Member
|
It's in my queue but I'm extra busy atm so it'll be a while yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt on addressing wixtoolset/issues#8785 and wixtoolset/issues#8786 by extending the WiX documentation to also cover these checks that I believe are quite common.
Disclaimer: This is my first PR to this project and I'm not familiar with "Docusaurus". Therefore, please let me know if the content should be placed elsewhere and if
sidebar_positionshould be changed to a different value. Also, please feel free to be picky on the wording and formatting proposal, and I'll do my best to accommodate the feedback. I can also split the proposal into two separate PRs if desired.References