Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds DMA (Direct Memory Access) support for AES-CBC operations in the wolfHSM cryptographic library. This extends the existing DMA capabilities (previously available for AES-GCM) to CBC mode.
- Implements
wh_Client_AesCbcDmafunction for client-side DMA operations - Adds server-side handler
_HandleAesCbcDmafor processing CBC DMA requests - Integrates CBC DMA into the crypto callback system
- Adds benchmark modules for AES-128 and AES-256 CBC encrypt/decrypt with DMA
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wolfhsm/wh_client_crypto.h | Added function declaration for wh_Client_AesCbcDma |
| src/wh_client_crypto.c | Implemented wh_Client_AesCbcDma with DMA address translation and IV handling |
| src/wh_client_cryptocb.c | Added WC_CIPHER_AES_CBC case to DMA crypto callback dispatcher |
| src/wh_server_crypto.c | Implemented _HandleAesCbcDma server handler and registered it in the DMA request dispatcher |
| test/wh_test_crypto.c | Removed conditional that previously disabled CBC testing for DMA device IDs |
| benchmark/wh_bench_ops.h | Increased MAX_BENCH_OPS from 88 to 92 to accommodate new benchmark modules |
| benchmark/wh_bench.c | Added four new benchmark module entries for CBC DMA operations |
| benchmark/bench_modules/wh_bench_mod_all.h | Added function declarations for CBC DMA benchmark modules |
| benchmark/bench_modules/wh_bench_mod_aes.c | Implemented benchmark functions for AES CBC DMA operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| } | ||
|
|
||
| /* Write out uptdated IV */ |
There was a problem hiding this comment.
Corrected spelling of 'uptdated' to 'updated'.
Suggested change
| /* Write out uptdated IV */ | |
| /* Write out updated IV */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.