Fix DeriveTls13Keys with no_key#9862
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for calling DeriveTls13Keys() with no_key (previously treated as an invalid secret type), and introduces a regression test to validate the new behavior.
Changes:
- Handle
no_keyexplicitly inDeriveTls13Keys()instead of returningBAD_FUNC_ARG. - Expose
DeriveTls13Keys()for test visibility and add a TLS 1.3 API test for theno_keypath. - Register the new test in the TLS 1.3 test suite header.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| wolfssl/internal.h | Changes DeriveTls13Keys() visibility to enable calling it from tests. |
| tests/api/test_tls13.h | Declares/registers the new tls13_derive_keys_no_key test. |
| tests/api/test_tls13.c | Adds a new test case exercising DeriveTls13Keys(..., no_key, ...). |
| src/tls13.c | Adds a case no_key: branch in DeriveTls13Keys() switch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Force pushed to resolve minor merge conflict in |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
The fix adds a
case no_key:to the switch statement inDeriveTls13Keys()Fixes zd21243
Testing
Added
tls13_derive_keys_no_keyChecklist