Fix for setting curve using all caps with wolfSSL_set1_curves_list#9863
Fix for setting curve using all caps with wolfSSL_set1_curves_list#9863douzzer merged 1 commit intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes ECC curve list handling so uppercase wolfCrypt curve names (e.g., SECP384R1) resolve correctly via the fallback path when kNistCurves doesn’t match due to case sensitivity.
Changes:
- Adjusted
set_curves_list()to use the correct resolved curve identifier when retrieving ECC params. - Added a TLS 1.3 API test that exercises the uppercase-name fallback behavior.
- Registered the new test in the TLS 1.3 API test suite.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/api/test_tls13.h | Registers the new TLS 1.3 test in declarations and test group list. |
| tests/api/test_tls13.c | Adds a regression test for uppercase curve name handling via fallback resolution. |
| src/ssl.c | Fixes curve-parameter lookup to use the fallback-resolved curve id. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Retest this please. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Retest this please Jenkins |
F-361