ascon: don't skip wc_AsconAEAD128_Clear on auth error.#9928
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Mar 11, 2026
Merged
ascon: don't skip wc_AsconAEAD128_Clear on auth error.#9928douzzer merged 1 commit intowolfSSL:masterfrom
douzzer merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where wc_AsconAEAD128_DecryptFinal would return early on an authentication error without first calling wc_AsconAEAD128_Clear, potentially leaving sensitive state (key material, intermediate cipher state) in memory.
Changes:
- Changed the auth tag mismatch handling to store the error code instead of returning immediately, ensuring
wc_AsconAEAD128_Clearis always called before returning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Retest this please. |
douzzer
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't skip
wc_AsconAEAD128_Clearon auth error.Fixes F-451.