Scope Reader photo viewer swiping to gallery images#22762
Open
Scope Reader photo viewer swiping to gallery images#22762
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Only use editorial.image, featured_image, or featured_media.uri as featured image sources instead of scanning post content for suitable images or videos. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reorder ConstraintLayout constraints so the visual hierarchy is: blog header → featured image → title → excerpt → interactions → footer Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a Reader post has a portrait featured image, the image is now scaled to fit the container height and centered horizontally with a gray background fill, instead of being center-cropped which often cuts off heads and other important content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move featured image from collapsing AppBar to inline in the header view with adaptive aspect ratio. Restructure blog section so site name, author, and date each appear on their own line with absolute date+time format. Add reading time indicator and excerpt display to the header. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Extract Regex and date format constants in header UI state builder - Replace verbose null-check patterns with setTextOrHide helper - Hoist Paint allocation to class property in PortraitAwareCropTransformation - Remove unnecessary list allocation in applyInteractionSectionTheme Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ibute Replace ?attr/colorOnSurfaceVariant (Material3-only) with compatible alternatives since the reading preferences ContextThemeWrapper uses Theme.MaterialComponents.DayNight which lacks this attribute. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…stener - Remove unused postDetailsHeaderViewUiStateBuilder injection from fragment - Replace per-scroll toolbar coloring with one-time setup in initAppBar - Inline trivial buildPostDetailsHeaderUiState delegation - Remove unnecessary default values in ReaderFeaturedImageUiState Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace HtmlCompat.fromHtml() with lighter HtmlUtils.fastStripHtml() for word counting, fix detekt ReturnCount and checkstyle empty-line violations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Chain blog name and author vertically against the avatar, add marginStart with goneMarginStart so text aligns flush when there is no avatar. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ptive-post-details Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move blog name to top, post title second, avatar with author and date below title, then featured image, blog description (up to 3 lines), and reading time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Anchor dateline start directly to avatar so it stays positioned when author name is hidden. Add barrier below blog name and follow button so the post title clears both. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
findPost() excludes the text column for performance, so shouldAddFeaturedImage() couldn't detect the image was already in the post body HTML. Fetch with text column included when returning from comments to preserve deduplication. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Flatten ReaderPostDetailsHeaderViewUiState sealed class into top-level data classes (only had one subclass) - Inline trivial wrapper methods in the header UI state builder - Inline single-line delegation methods in the header view Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…d, rename excerpt to blogDescription - Cache SimpleDateFormat as a class property instead of allocating per call - Wrap ReaderBlogTableWrapper.getBlogInfo() in withContext(Dispatchers.IO) and propagate suspend through the call chain - Rename excerpt/text_excerpt to blogDescription/text_blog_description since the field shows blog description, not post excerpt Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This drawable was only referenced by the collapsing toolbar featured image FrameLayout which was removed in the header redesign. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove redundant likeCount/commentCount local variables - Simplify featured image null handling with if/else - Make ReaderFeaturedImageUiState.url and onFeaturedImageClicked non-null since the state object is only created with valid values - Rewrite buildReadingTime with early returns for readability Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…1997-reader-empty-title
When tapping an image inside a gallery block, the full-screen photo viewer now only allows swiping between images in that specific gallery instead of all images in the post. Uses WebView JS evaluation to detect gallery containers and extract their image URLs at tap time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The HitTestResult returns the full-size image URL (e.g., image.jpg) while the DOM img src contains the resized variant (e.g., image-819x1024.jpg). Strip the -WxH size suffix before comparing pathnames so gallery images are correctly matched. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix duplicate first image in gallery viewer by matching the initial URL to its resized gallery variant (stripping -WxH size suffixes) - Route anchor-wrapped images to onImageUrlClick when the anchor href points to an image URL, so gallery images linked to media files open in the photo viewer instead of navigating to a web page Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Trust WebView's HitTestResult type (IMAGE_TYPE, SRC_IMAGE_ANCHOR_TYPE) for image detection instead of relying solely on UrlUtils.isImageUrl() which only recognizes jpg/jpeg/gif/png. For anchor-wrapped images, only defer to WebView for fragment links (footnote back-references); all other cases route to the photo viewer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Merge the duplicate 7-param and 8-param showReaderPhotoViewer overloads into a single method with a default parameter. Remove unnecessary @Suppress("LongMethod") from showPhotoViewerWithGalleryCheck. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
|
Contributor
|
|
Move java.util.ArrayList import to correct position after android/ androidx groups. Add comment explaining single-image gallery fallback and Javadoc on stripSizeSuffix cross-referencing the JS counterpart. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private boolean mIsPrivate; | ||
| private boolean mIsGallery; | ||
| private String mContent; | ||
| private ArrayList<String> mGalleryImageUrls; |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on field Note
Extract gallery collection JS into separate method to fix LongMethod, restructure parseGalleryUrlsResult to fix ReturnCount, and fix import ordering in ReaderPhotoViewerActivity. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22762 +/- ##
==========================================
- Coverage 37.40% 37.39% -0.01%
==========================================
Files 2320 2321 +1
Lines 123674 123706 +32
Branches 16791 16796 +5
==========================================
Hits 46256 46256
- Misses 73707 73739 +32
Partials 3711 3711 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace manual DOM walking with closest() and merge two JS builder methods into one, reducing the gallery detection code by ~40 lines. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move JS building and result parsing out of the already-large ReaderPostDetailFragment into a focused, reusable class. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, tapping an image in a gallery would show that image full screen and enable swiping between images, but instead of swiping through just the images in that gallery it would swipe between all images in the post. This PR resolves this by only swiping through the gallery's images.
Testing instructions
Gallery-scoped swiping:
Multiple galleries:
gallery.mp4