Upgrade GutenbergKit from v0.11.1 to v0.15.0#22764
Open
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
Project dependencies changeslist+ New Dependencies
org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3
org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.7.3
! Upgraded Dependencies
org.wordpress.gutenbergkit:android:v0.15.0, (changed from v0.11.1)tree++--- androidx.navigation:navigation-compose:2.9.7
+| \--- androidx.navigation:navigation-compose-android:2.9.7
+| \--- androidx.activity:activity:1.8.0 -> 1.10.1
+| \--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.6.1 -> 2.10.0
+| \--- androidx.lifecycle:lifecycle-viewmodel-savedstate-android:2.10.0
+| \--- androidx.savedstate:savedstate:1.4.0
+| \--- androidx.savedstate:savedstate-android:1.4.0
+| \--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3
+| \--- org.jetbrains.kotlinx:kotlinx-serialization-core-jvm:1.7.3
+| \--- org.jetbrains.kotlinx:kotlinx-serialization-bom:1.7.3
+| +--- org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.7.3 (c)
+| \--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3 (c)
+--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:v0.11.1
-| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:2.0.21 -> 2.3.20 (*)
-| +--- androidx.core:core-ktx:1.13.1 -> 1.16.0 (*)
-| +--- androidx.appcompat:appcompat:1.7.0 -> 1.7.1 (*)
-| +--- com.google.android.material:material:1.12.0 (*)
-| +--- androidx.webkit:webkit:1.11.0 -> 1.15.0 (*)
-| +--- com.google.code.gson:gson:2.8.9 -> 2.13.2
-| | \--- com.google.errorprone:error_prone_annotations:2.41.0
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.10.2 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 -> 2.3.20 (*)
+| \--- org.wordpress.gutenbergkit:android:v0.15.0
+| +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:2.1.21 -> 2.3.20 (*)
+| +--- androidx.core:core-ktx:1.13.1 -> 1.16.0 (*)
+| +--- androidx.appcompat:appcompat:1.7.0 -> 1.7.1 (*)
+| +--- com.google.android.material:material:1.12.0 (*)
+| +--- androidx.webkit:webkit:1.11.0 -> 1.15.0 (*)
+| +--- com.google.code.gson:gson:2.8.9 -> 2.13.2
+| | \--- com.google.errorprone:error_prone_annotations:2.41.0
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.10.2 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.7.3
+| | \--- org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.7.3
+| | +--- org.jetbrains.kotlinx:kotlinx-serialization-bom:1.7.3 (*)
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.20 -> 2.3.20 (*)
+| | \--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.7.3 (*)
+| +--- org.jsoup:jsoup:1.18.1 -> 1.22.1
+| +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.2 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.3.20 (*)
-\--- org.wordpress.gutenbergkit:android:v0.11.1 (*)
+\--- org.wordpress.gutenbergkit:android:v0.15.0 (*) |
Contributor
|
|
Contributor
|
|
d538543 to
865899d
Compare
e051e55 to
f861ada
Compare
Adapt to breaking API changes in GutenbergKit v0.15.0: - GutenbergView.createForEditor() removed: use GutenbergView constructor with configuration, dependencies, coroutineScope, and context parameters - gutenbergView.start(config) removed: EditorConfiguration must be provided at construction time - EditorConfiguration moved from org.wordpress.gutenberg to org.wordpress.gutenberg.model - EditorConfiguration.Builder() replaced with EditorConfiguration.builder(siteURL, siteApiRoot, postType) - setPostId(Int?) changed to setPostId(UInt?) - GutenbergView.warmup() removed: warmup helper is now a no-op The fragment's two-phase flow (create view now, start with editor settings later) is replaced by providing the full EditorConfiguration at fragment/view construction time.
f861ada to
6cfa2a2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22764 +/- ##
=======================================
Coverage 37.40% 37.40%
=======================================
Files 2320 2320
Lines 123674 123654 -20
Branches 16791 16793 +2
=======================================
Hits 46256 46256
+ Misses 73707 73687 -20
Partials 3711 3711 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Minimal upgrade of GutenbergKit from v0.11.1 to v0.15.0, adapting to breaking API changes without additional refactoring.
Breaking changes addressed:
GutenbergView.createForEditor()removed → useGutenbergView(configuration, dependencies, coroutineScope, context)constructorgutenbergView.start(config)removed →EditorConfigurationprovided at construction timeEditorConfigurationmoved fromorg.wordpress.gutenbergtoorg.wordpress.gutenberg.modelEditorConfiguration.Builder()replaced withEditorConfiguration.builder(siteURL, siteApiRoot, postType)(required params)setPostId(Int?)→setPostId(UInt?)GutenbergView.warmup()removed → warmup helper is now a no-op (to be reimplemented separately)The fragment's two-phase flow (create view now, start with editor settings later via
onEditorSettingsChanged) is replaced by providing the fullEditorConfigurationat fragment/view construction time.The existing
GutenbergKitSettingsBuilderwith its config data classes is unchanged — refactoring that is a separate effort.Test plan
./gradlew :WordPress:testJetpackDebugUnitTest --tests "*GutenbergKit*"— all tests pass