Skip to content

fix: resolve retain cycle in GutenbergCoverUploadProcessor #25442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amanjeetsingh150 wants to merge 1 commit into from
+4 −3
Closed

fix: resolve retain cycle in GutenbergCoverUploadProcessor #25442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergCoverUploadProcessor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,10 @@ class GutenbergCoverUploadProcessor: Processor {
self.remoteURLString = remoteURLString
}

lazy var coverBlockProcessor = GutenbergBlockProcessor(for: CoverBlockKeys.name, replacer: { coverBlock in
guard let mediaID = coverBlock.attributes[CoverBlockKeys.id] as? Int,
mediaID == self.mediaUploadID else {
lazy var coverBlockProcessor = GutenbergBlockProcessor(for: CoverBlockKeys.name, replacer: { [weak self] coverBlock in
guard let self,
let mediaID = coverBlock.attributes[CoverBlockKeys.id] as? Int,
mediaID == self.mediaUploadID else {
return nil
}
var block = "<!-- \(CoverBlockKeys.name) "
Expand Down