Skip to content

Improve device vendor string detection#758

Open
whitebelyash wants to merge 2 commits intoxCollateral:devfrom
whitebelyash:fix/dev-id
Open

Improve device vendor string detection#758
whitebelyash wants to merge 2 commits intoxCollateral:devfrom
whitebelyash:fix/dev-id

Conversation

@whitebelyash
Copy link

Current code supports only AMD/NVIDIA/Intel, additionally, AMD has broken id not present on most modern AMD GPUs. This pull request:

  • Fixes AMD vendorId - 0x1002. Though, I'm not sure if 0x1022 is valid too, so I left it in place as well.
  • Adds vendorId decoding for less common Vulkan devices such as Apple & Qualcomm. You may say VulkanMod doesn't support non-PC platforms (i.e. Android), however, SBCs with these 3D accelerators do exist. Additionally, Apple & Qualcomm are present on the consumer PC market.

Some are used on PC (like Qualcomm on WoA or Apple Silicon), so might be useful. Haven't touched the driver version detection logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant