sets.json: File is 'dark720p_xxx' not 'dark70p_xxx'#113
Open
xiphmont wants to merge 1 commit intoxiph:masterfrom
Open
sets.json: File is 'dark720p_xxx' not 'dark70p_xxx'#113xiphmont wants to merge 1 commit intoxiph:masterfrom
xiphmont wants to merge 1 commit intoxiph:masterfrom
Conversation
Contributor
Author
|
BTW-- the merge and revert were because of a github misfire on my part; I hadn't intended to override review and merge unilaterally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this typo has always been there and folks were either renaming the file in the set, or the file in the set was misnamed back then too. These days, the test sets up for download at xiph have the correct filename, and this caused a bit of a headscratcher for a while (because typos are hard to spot, especially when there's a second bug there that looks identical).