Don't treat two different consecutive flashes as repeating #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by not comparing the previous frame's flash parameters during the repeating flash check. The issue can be reproduced in maps with parallel flash+wait by using a flashing effect action like the rat form toggle in Collective Unconscious or rainbow/fairy in Yume 2kki. The effect action triggers the repeating flash condition, even though the two flashes have different parameters. Examples of affected maps: - Yume 2kki: MAP0160 (Monochrome Street) - Yume 2kki: MAP0703 (Florist) - Yume 2kki: MAP3594 (Firefly Lake) - Collective Unconscious: MAP1407 (Forest) Regression introduced in a545830.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by not comparing the previous frame's flash parameters during the repeating flash check.
The issue can be reproduced in maps with parallel flash+wait by using a flashing effect action like the rat form toggle in Collective Unconscious or rainbow/fairy in Yume 2kki. The effect action triggers the repeating flash condition even though the two flashes have different parameters.
Examples of affected maps:
Regression introduced in a545830, an alternative fix would be to revert it.