Further tests #49
Open
Further tests #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
brokkoli71
commented
Jan 26, 2026
brokkoli71
commented
- fixes [v2] Further Tests #20
# Conflicts: # src/test/java/dev/zarr/zarrjava/TestUtils.java
normanrz
reviewed
Jan 26, 2026
| } | ||
|
|
||
| @Test | ||
| public void testUpdateAttributesBehavior() throws IOException, ZarrException { |
Member
There was a problem hiding this comment.
In Zarr v2, should the .zattrs file be deleted if there are no attributes? Can you check what zarr-python does?
Member
Author
There was a problem hiding this comment.
zarr-python always creates and keeps the .zattrs for groups and arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.