Reduce usage of expectEqual in behavior tests#25791
Open
jeffective wants to merge 1 commit intoziglang:masterfrom
Open
Reduce usage of expectEqual in behavior tests#25791jeffective wants to merge 1 commit intoziglang:masterfrom
jeffective wants to merge 1 commit intoziglang:masterfrom
Conversation
Contributor
Author
|
Looks like windows CI failure is #22510 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not fully close #24361 (this is only a first, simple change set)
Summary:
expectEqual(x, y)toexpect(x == y)for files intest/behavior/**My editor was configured to re-order imports on save. Hope that isn't a huge issue.
Verification evidence:
note: I had closed my previous PR to prevent unintended CI runs during rebase etc #24389
note to self: use this for testing if you have to rebase again: