Fix: Cannot read properties of undefined (reading 'offsetHeight') (T1321478)#32868
Open
ajivanyandev wants to merge 3 commits intoDevExpress:26_1from
Open
Fix: Cannot read properties of undefined (reading 'offsetHeight') (T1321478)#32868ajivanyandev wants to merge 3 commits intoDevExpress:26_1from
ajivanyandev wants to merge 3 commits intoDevExpress:26_1from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a runtime error in DevExtreme’s internal animation/positioning utilities that could occur when APIs are invoked with an empty/unmounted element (e.g., after a widget is removed from the DOM).
Changes:
- Removed the
offsetHeightread inresetPositionthat could throw when the wrapped element is missing. - Added an early return in
position(m_position.setup) when the target element doesn’t exist. - Added Jest coverage for
resetPositionandpositionUtils.setupwith missing/empty elements.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/common/core/animation/translator.ts |
Avoids crashing when finishing a transition on an empty wrapper by removing the offsetHeight access. |
packages/devextreme/js/__internal/common/core/animation/translator.test.ts |
Adds Jest tests ensuring resetPosition(..., true) doesn’t throw for missing/empty elements. |
packages/devextreme/js/__internal/common/core/animation/m_position.ts |
Returns undefined early when what resolves to an empty element wrapper, preventing downstream errors. |
packages/devextreme/js/__internal/common/core/animation/m_position.test.ts |
Adds Jest tests for positionUtils.setup behavior with missing/empty elements (currently only for the no-options path). |
packages/devextreme/js/__internal/common/core/animation/m_position.test.ts
Show resolved
Hide resolved
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.