Add impact sound effects for physics collisions#6
Open
jdarc wants to merge 1 commit intoKenneyNL:mainfrom
Open
Add impact sound effects for physics collisions#6jdarc wants to merge 1 commit intoKenneyNL:mainfrom
jdarc wants to merge 1 commit intoKenneyNL:mainfrom
Conversation
Contributor
|
Works well! Where is the impact sound from and what is it's associated license? That has to be mentioned. |
Author
|
Impact sound was extract from https://kenney.nl/assets/impact-sounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add impact sound effects for vehicle collisions
Collisions against the vehicle's RigidBody3D now emit an impact sound, adding a tactile feel when hitting barriers.
Technical Changes:
Contact Monitoring: Increased max_contacts_reported to 2 to ensure simultaneous hits (e.g., floor and wall) are captured.
Dynamic Volume: Altered the linear_db based on impact force so direct hits are louder than skimming ones.
Velocity Logic: Calculated impact velocity manually; using the built-in linear_velocity of rigid body caused inconsistent behavior, the orientation of the rigid body with a sphere shape and the orientation of the vehicle nodes are not the same.