feat!: Expose Assets-owned controller/service methods through messenger#8164
Merged
GuillaumeRx merged 13 commits intomainfrom Mar 11, 2026
Merged
feat!: Expose Assets-owned controller/service methods through messenger#8164GuillaumeRx merged 13 commits intomainfrom
GuillaumeRx merged 13 commits intomainfrom
Conversation
d7491b8 to
c0b6e4c
Compare
packages/assets-controllers/src/MultichainAssetsRatesController/index.ts
Show resolved
Hide resolved
packages/network-enablement-controller/src/NetworkEnablementController.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
1790154 to
6ea81c2
Compare
… `network-enablement-controller`
… `assets-controllers`
…llers` CHANGELOG
4936245 to
c02571d
Compare
Prithpal-Sooriya
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Exposes all the public methods other than internally used methods of the assets-owned controllers/services through the messenger.
This also refactors how actions are defined and bound to the messenger using
registerMethodActionHandlersandMESSENGER_EXPOSED_METHODS.The
generate-method-action-typescript was used to generate the action types.This is a breaking change in the
AccountTrackerControllerpackage as some of the action type names changed but none of the underlying signatures changed.References
Checklist
Note
Medium Risk
Medium risk due to widespread refactor of messenger action typing/registration across assets and network enablement controllers, including breaking TypeScript type renames that can impact downstream builds. Runtime behavior should be mostly unchanged, but incorrect
MESSENGER_EXPOSED_METHODSlists could unintentionally expose/omit actions.Overview
Standardizes how multiple controllers expose public methods via the messenger by switching from per-action
registerActionHandlercode toregisterMethodActionHandlerswith explicitMESSENGER_EXPOSED_METHODSallowlists.Adds auto-generated
*-method-action-types.tsfiles (and newgenerate-method-action-typesscripts/tsxdev dependency) and updates exports/imports accordingly, including newly exposed actions such asAssetsContractController:getStakedBalanceForChain,MultichainAssetsRatesController:fetchHistoricalPricesForAsset, and severalTokenDetectionController/TokensControllermethods.Introduces breaking renames of messenger action type aliases (not action strings) for
AccountTrackerControllerandNetworkEnablementController, and updates related tests/changelogs to match.Written by Cursor Bugbot for commit c02571d. This will update automatically on new commits. Configure here.