Open
Conversation
ccharly
force-pushed
the
cc/chore/bump-accounts-deps
branch
from
c2f9e74 to
376fd49
Compare
Contributor
Author
|
@metamaskbot publish-preview |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
Added Not sure if there's a better way to handle this for changelogs? |
ccharly
commented
Apr 15, 2026
Comment on lines
+87
to
+94
| '^@metamask/eth-hd-keyring/v2$': | ||
| '<rootDir>/../../node_modules/@metamask/eth-hd-keyring/dist/v2/index.cjs', | ||
| '^@metamask/eth-simple-keyring/v2$': | ||
| '<rootDir>/../../node_modules/@metamask/eth-simple-keyring/dist/v2/index.cjs', | ||
| '^@metamask/keyring-api/v2$': | ||
| '<rootDir>/../../node_modules/@metamask/keyring-api/dist/v2/index.cjs', | ||
| '^@metamask/keyring-sdk/v2$': | ||
| '<rootDir>/../../node_modules/@metamask/keyring-sdk/dist/v2/index.cjs', |
Contributor
Author
There was a problem hiding this comment.
Somehow, jest is not able to resolve that without doing it explicitly 😅
montelaidev
reviewed
Apr 15, 2026
| KnownCaipNamespace, | ||
| KnownCaipNamespace.Wallet | ||
| >; | ||
| export type NonWalletKnownCaipNamespace = |
Contributor
There was a problem hiding this comment.
Do we need one for stellar?
Contributor
Author
There was a problem hiding this comment.
Well, I wasn't sure if there was some more logic needed in the package (not my domain here 😅)
So I preferred to just use an explicit enumeration instead (to avoid having other breaking change in the future). But I'll let the wallet API team to guide me on this one.
But indeed, given the name, we could re-use the Exclude and declare the missing field for the type that relies on it (but that could be seen as a breaking change though..)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Bumping all
accountsdeps to the latest. Mostly including the new/v2exports for the on-going work with the keyring API v2.References
N/A
Checklist
Note
Medium Risk
Primarily dependency bumps, but it also changes keyring-related imports to use new
/v2entrypoints and updates account type ordering, which could affect runtime behavior and tests if any API contracts changed.Overview
Updates the accounts/keyring dependency set across multiple packages, notably bumping
@metamask/keyring-apito^23.0.0(plus related bumps likeeth-hd-keyring,eth-simple-keyring,eth-snap-keyring,keyring-internal-api, andkeyring-snap-client) and aligning changelogs/lockfile accordingly.Adapts code to the Keyring API v2 transition by switching several type/value imports to
@metamask/*/v2(e.g.,KeyringController’s v2 keyring builders and tests, andKeyringCapabilitiesusage inmultichain-account-service), and adds temporary JestmoduleNameMapperoverrides so/v2subpath imports resolve to published builds.Adds Stellar account-type sort ordering (
XlmAccountType) inaccount-tree-controller, and hardensNonWalletKnownCaipNamespaceto an explicit allowlist to avoid unintended type expansion when new CAIP namespaces are introduced.Reviewed by Cursor Bugbot for commit 531556e. Bugbot is set up for automated code reviews on this repo. Configure here.