-
-
Notifications
You must be signed in to change notification settings - Fork 274
chore: bump accounts deps
#8464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
376fd49
51fb952
f0eb47e
1e05a39
2b40d63
d2b5653
e1f1895
f8c35a1
548bdd1
531556e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,10 +116,14 @@ export const parseScopeString = ( | |
| /** | ||
| * CAIP namespaces excluding "wallet" currently supported by/known to the wallet. | ||
| */ | ||
| export type NonWalletKnownCaipNamespace = Exclude< | ||
| KnownCaipNamespace, | ||
| KnownCaipNamespace.Wallet | ||
| >; | ||
| export type NonWalletKnownCaipNamespace = | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need one for stellar?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, I wasn't sure if there was some more logic needed in the package (not my domain here 😅) So I preferred to just use an explicit enumeration instead (to avoid having other breaking change in the future). But I'll let the wallet API team to guide me on this one. But indeed, given the name, we could re-use the |
||
| // NOTE: Using explicit enum values to avoid having breaking change when | ||
| // `KnownCaipNamespace` is updated with new namespaces that we don't yet | ||
| // support. | ||
| | KnownCaipNamespace.Eip155 | ||
| | KnownCaipNamespace.Bip122 | ||
| | KnownCaipNamespace.Solana | ||
| | KnownCaipNamespace.Tron; | ||
|
|
||
| /** | ||
| * Checks if a scope string is either a 'wallet' scope or a 'wallet:*' scope. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow, jest is not able to resolve that without doing it explicitly 😅