fix(transaction-controller): broaden gas estimation for type-4 transactions with non-self target#8467
Draft
matthewwalsh0 wants to merge 1 commit intomainfrom
Draft
fix(transaction-controller): broaden gas estimation for type-4 transactions with non-self target#8467matthewwalsh0 wants to merge 1 commit intomainfrom
matthewwalsh0 wants to merge 1 commit intomainfrom
Conversation
…ctions with non-self target Broaden isUpgradeWithData condition to support type-4 transactions where to != from (e.g. enforced simulations targeting the delegation manager). Override to=from in the upgrade-only estimation since a bare 7702 authorization upgrade is always a self-transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The existing
isUpgradeWithDataToSelfcondition in gas estimation requiresfrom === tofor the split estimation path (upgrade gas + execution gas). This doesn't work for enforced simulations wheretois the delegation manager, not the sender.Changes:
isUpgradeWithData(nofrom === tocheck) andisUpgradeWithDataToSelf(preserves the original for downstream use)isUpgradeWithDatato gate the split estimation path — any type-4 transaction with an authorization list and data qualifiesto: txParams.fromin the upgrade-only estimation (step 1) since a bare 7702 authorization upgrade is always a self-transaction, regardless of the actual transaction targetReferences
Companion to MetaMask/metamask-extension#41775
Changelog
@metamask/transaction-controllerChanged
todiffers fromfromfromaddress for accurate 7702 upgrade gas calculation