Skip to content

fix(transaction-controller): broaden gas estimation for type-4 transactions with non-self target #8467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
matthewwalsh0 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Draft

fix(transaction-controller): broaden gas estimation for type-4 transactions with non-self target #8467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/transaction-controller/src/utils/gas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,15 +140,17 @@ export async function estimateGas({
let estimatedGas = fallback;
let simulationFails: TransactionMeta['simulationFails'];

const isUpgradeWithDataToSelf =
const isUpgradeWithData =
txParams.type === TransactionEnvelopeType.setCode &&
Boolean(authorizationList?.length) &&
Boolean(data) &&
data !== '0x' &&
data !== '0x';

const isUpgradeWithDataToSelf = isUpgradeWithData &&
from?.toLowerCase() === to?.toLowerCase();

try {
if (isSimulationEnabled && isUpgradeWithDataToSelf) {
if (isSimulationEnabled && isUpgradeWithData) {
estimatedGas = await estimateGasUpgradeWithDataToSelf(
request,
messenger,
Expand Down Expand Up @@ -570,6 +572,7 @@ async function estimateGasUpgradeWithDataToSelf(
params: [
{
...txParams,
to: txParams.from,
data: '0x',
},
],
Expand Down
Loading