-
Notifications
You must be signed in to change notification settings - Fork 9.1k
chore: bump bun to v1.3.6 #8865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps the Bun runtime and TypeScript definitions from version 1.3.5 to 1.3.6. The changes update the package manager specification and corresponding type definitions in the project's dependency catalog.
Changes:
- Updated Bun package manager from 1.3.5 to 1.3.6
- Updated @types/bun and bun-types dependencies to match the new version
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated packageManager field and @types/bun catalog entry to version 1.3.6 |
| bun.lock | Updated lock file entries for @types/bun and bun-types to version 1.3.6 with new SHAs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This also fixes the nix build, since it is now broken due to version mismatch: › nix run github:anomalyco/opencode
error: builder for '/nix/store/llfmmbgm0nxsv45j1rxrnxix9w2ch1gb-opencode-1.1.25-0924286.drv' failed with exit code 1;
last 19 log lines:
> Using versionCheckHook
> Running phase: unpackPhase
> unpacking source archive /nix/store/jlz9fd43302q5sdgm4q39la5p324fp16-source
> source root is source
> Running phase: patchPhase
> Running phase: updateAutotoolsGnuConfigScriptsPhase
> Running phase: configurePhase
> Running phase: buildPhase
> 8 | if (!expectedBunVersion) {
> 9 | throw new Error("packageManager field not found in root package.json")
> 10 | }
> 11 |
> 12 | if (process.versions.bun !== expectedBunVersion) {
> 13 | throw new Error(`This script requires bun@${expectedBunVersion}, but you are using bun@${process.versions.bun}`)
> ^
> error: This script requires [email protected], but you are using [email protected]
> at /build/source/packages/script/src/index.ts:13:13
>
> Bun v1.3.6 (Linux x64)
For full logs, run:
nix log /nix/store/llfmmbgm0nxsv45j1rxrnxix9w2ch1gb-opencode-1.1.25-0924286.drv |
|
There was some bun regression hence the downgrade btw |
|
We tested your branch 'chore/bump-bun-1.3.6' on our NixOS system, but it failed with a hash mismatch in the opencode-node_modules derivation. The branch updates package.json and bun.lock to Bun 1.3.6, but nix/hashes.json still has the old SHA256 for node_modules. To fix, update nix/hashes.json with the new hash for the updated dependencies. Alternatively, our PRs #9597 and #9618 include complete fixes with semver range support and exact pinning respectively, both including the necessary nix/hashes.json updates. See also: #9583 (comment) for details on why nix hashes are required. |
Detailed Investigation Report: PR #8865 and Nix Hash UpdatesIssue SummaryPR #8865 updates OpenCode to use Bun 1.3.6 by modifying Testing Results
Key FindingThe
RecommendationMerge PR #8865 to Related PRs/Issues
This ensures the PR fully resolves the issue once integrated into the main branch. |
|
Fixes #9583 |
|
@Hona The 'needs:issue' label didn't disappear because the linking keyword must be in the PR description, not comments. Please update the PR description to include 'Fixes #9583' (or 'Closes #9583') at the beginning or end. This will automatically link the issue and remove the label per CONTRIBUTING.md requirements. Proposed Full Description: Fixes #9583
## What does this PR do?
Bumps Bun runtime and TypeScript definitions from 1.3.5 to 1.3.6 to resolve version mismatch errors in Nix builds.
## Changes
- Updates `packageManager` field in `package.json` to `[email protected]`
- Updates `@types/bun` catalog entry to version 1.3.6
- Regenerates `bun.lock` with updated dependency hashes
## Motivation
The Nix flake currently uses Bun 1.3.6, but the build script expects 1.3.5, causing failures. This PR aligns the project with the runtime version.
## How did you verify your code works?
`bun dev` (tui smokecheck)
typecheck + cicd tests
## Additional Notes
- Merging to `dev` will trigger automated hash updates for Nix builds
- Verified Bun 1.3.6 compatibility |
00637c0 to
71e0ba2
Compare
f1ae801 to
08fa7f7
Compare
What does this PR do?
title
How did you verify your code works?
bun dev(tui smokecheck)typecheck + cicd tests