Skip to content

Fix #21317: Replace colons with underscores in window filenames for Windows compatibility #37821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liferoad wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −1
Open

Fix #21317: Replace colons with underscores in window filenames for Windows compatibility #37821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fded129
Fix #21317: Replace colons with underscores in window filenames for W…
liferoad Mar 11, 2026
d91be41
fix: Add null check for the `os.name` system property before checking…
liferoad Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sdks/java/core/src/main/java/org/apache/beam/sdk/io/DefaultFilenamePolicy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,16 @@ private String windowToString(BoundedWindow window) {
}
if (window instanceof IntervalWindow) {
IntervalWindow iw = (IntervalWindow) window;
return String.format("%s-%s", iw.start().toString(), iw.end().toString());
// Use ISO-8601 format but replace colons with underscores for Windows compatibility
// since colons are illegal characters in Windows file paths.
String startStr = iw.start().toString();
String endStr = iw.end().toString();
String osName = System.getProperty("os.name");
if (osName != null && osName.startsWith("Windows")) {
startStr = startStr.replace(':', '_');
endStr = endStr.replace(':', '_');
}
return String.format("%s-%s", startStr, endStr);
}
return window.toString();
}
Expand Down
Loading