Open
Conversation
…vices with no specific config The LoadSpecificConfig codegen template produces an empty function body for services that don't match any conditional block (e.g. DynamoDB Streams), leaving inputProfileName unused. This fails compilation with -Werror. Add AWS_UNREFERENCED_PARAM(inputProfileName) unconditionally to the template.
sbiscigl
reviewed
Apr 16, 2026
| #end | ||
| void ${metadata.classNamePrefix}ClientConfiguration::Load${serviceNamespace}SpecificConfig(const Aws::String& inputProfileName) | ||
| { | ||
| AWS_UNREFERENCED_PARAM(inputProfileName); |
Collaborator
There was a problem hiding this comment.
you put this regardless if it is used or not, for instance in S3 you will put AWS_UNREFERENCED_PARAM(inputProfileName); then immediately use it. you should only use this if its truly unused.
…vices with no specific config The LoadSpecificConfig codegen template produces an empty function body for services that don't match any conditional block (e.g. DynamoDB Streams), leaving inputProfileName unused. This fails compilation with -Werror. Add AWS_UNREFERENCED_PARAM(inputProfileName) unconditionally to the template.
…vices with no specific config The LoadSpecificConfig codegen template produces an empty function body for services that don't match any conditional block (e.g. DynamoDB Streams), leaving inputProfileName unused. This fails compilation with -Werror. Add AWS_UNREFERENCED_PARAM(inputProfileName) unconditionally to the template.
…vices with no specific config The LoadSpecificConfig codegen template produces an empty function body for services that don't match any conditional block (e.g. DynamoDB Streams), leaving inputProfileName unused. This fails compilation with -Werror. Add AWS_UNREFERENCED_PARAM(inputProfileName) unconditionally to the template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix -Wunused-parameter error in generated ClientConfiguration for services with no specific config
The LoadSpecificConfig codegen template produces an empty function body for services that don't match any conditional block (e.g. DynamoDB Streams), leaving inputProfileName unused. This fails compilation with -Werror.
Add AWS_UNREFERENCED_PARAM(inputProfileName) unconditionally to the template.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.