Skip to content

Fix -Wunused-parameter error in codegen #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kai-ion wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix -Wunused-parameter error in codegen #3798

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3398026
Fix -Wunused-parameter error in generated ClientConfiguration for ser…
kai-ion Apr 16, 2026
e25f048
Fix -Wunused-parameter error in generated ClientConfiguration for ser…
kai-ion Apr 16, 2026
0f40b19
Fix -Wunused-parameter error in generated ClientConfiguration for ser…
kai-ion Apr 16, 2026
71624d8
Fix -Wunused-parameter error in generated ClientConfiguration for ser…
kai-ion Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...amazonaws/util/awsclientgenerator/velocity/cpp/common/ServiceClientConfigurationSource.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,11 @@ bool IsEndpointDiscoveryEnabled(const Aws::String& endpointOverride, const Aws::
}

#end
#set($inputProfileNameUsed = false)
void ${metadata.classNamePrefix}ClientConfiguration::Load${serviceNamespace}SpecificConfig(const Aws::String& inputProfileName)
{
#if($serviceModel.metadata.serviceId == "S3")
#set($inputProfileNameUsed = true)
if (Aws::${serviceNamespace}::US_EAST_1_REGIONAL_ENDPOINT_OPTION::NOT_SET == this->useUSEast1RegionalEndPointOption)
{
const Aws::String& useUSEastOption =
Expand Down Expand Up @@ -111,6 +113,7 @@ void ${metadata.classNamePrefix}ClientConfiguration::Load${serviceNamespace}Spec

#end
#if($serviceModel.metadata.serviceId == "S3" || $serviceModel.metadata.serviceId == "S3 Control")
#set($inputProfileNameUsed = true)
Aws::String useArnRegionCfg = ClientConfiguration::LoadConfigFromEnvOrProfile(S3_USE_ARN_REGION_ENVIRONMENT_VARIABLE,
inputProfileName,
S3_USE_ARN_REGION_CONFIG_FILE_OPTION,
Expand All @@ -122,6 +125,7 @@ void ${metadata.classNamePrefix}ClientConfiguration::Load${serviceNamespace}Spec
}
#end
#if($metadata.hasEndpointDiscoveryTrait)
#set($inputProfileNameUsed = true)
if(!enableEndpointDiscovery) {
enableEndpointDiscovery = IsEndpointDiscoveryEnabled(this->endpointOverride, inputProfileName);
}
Expand All @@ -137,6 +141,7 @@ void ${metadata.classNamePrefix}ClientConfiguration::Load${serviceNamespace}Spec
#end
## Bedrock API key auth
#if($serviceModel.metadata.signingName == "bedrock")
#set($inputProfileNameUsed = true)
const Aws::String& bedrockToken =
BaseClientConfigClass::LoadConfigFromEnvOrProfile(AWS_BEARER_TOKEN_BEDROCK,
inputProfileName,
Expand All @@ -151,6 +156,9 @@ void ${metadata.classNamePrefix}ClientConfiguration::Load${serviceNamespace}Spec
authPreferences.insert(authPreferences.begin(), "bearer");
}
#end
#if(!$inputProfileNameUsed)
(void)(inputProfileName);
#end
}

${metadata.classNamePrefix}ClientConfiguration::${metadata.classNamePrefix}ClientConfiguration(const Aws::Client::ClientConfigurationInitValues &configuration)
Expand Down
Loading