Conversation
* Add CRT HTTP/2 support * Update CRT version and re-add back comments # Conflicts: # pom.xml
| private final HttpExecuteRequest request; | ||
| private final long readBufferSize; | ||
| private final HttpClientConnectionManager crtConnPool; | ||
| private final HttpStreamManager crtConnPool; |
There was a problem hiding this comment.
trivial: maybe rename this? It's not a connection pool anymore?
...-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/CrtUtils.java
Show resolved
Hide resolved
| ClientBootstrap clientBootstrap = new ClientBootstrap(null, null); | ||
| SocketOptions clientSocketOptions = buildSocketOptions(builder.getTcpKeepAliveConfiguration(), | ||
| config.get(SdkHttpConfigurationOption.CONNECTION_TIMEOUT)); | ||
| TlsContextOptions clientTlsContextOptions = | ||
| TlsContextOptions.createDefaultClient() | ||
| .withCipherPreference(resolveCipherPreference(builder.getPostQuantumTlsEnabled())) | ||
| .withVerifyPeer(!config.get(SdkHttpConfigurationOption.TRUST_ALL_CERTIFICATES)); |
There was a problem hiding this comment.
why we remove the try with resource block? Maybe I am not following the logic, but where do we clean up these resource?
There was a problem hiding this comment.
So previously, we have this subresource.addRef() process to increase reference every time we use it and then try with resource to close it. I just removed both to keep the logic simple.
* Add stability tests and JMH tests # Conflicts: # services/kinesis/src/it/java/software/amazon/awssdk/services/kinesis/AbstractTestCase.java * Fix tests * Fix checkstyle errors * Address feedback
|
2 participants
Merge CRT H2 Support