Skip to content

[DO NOT MERGE] Merge CRT H2 Support #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zoewangg wants to merge 8 commits into
base: master
Choose a base branch
from

Minor refactoring to rename variables (#6763)

c447fe3
Select commit
Loading
Failed to load commit list.
Open

[DO NOT MERGE] Merge CRT H2 Support #6729

Minor refactoring to rename variables (#6763)
c447fe3
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 6, 2026 in 14m 36s

Quality Gate failed

Failed conditions
64.6% Coverage on New Code (required ≥ 80%)
4.8% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 99 in test/sdk-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apicall/httpclient/async/NettyHttpClientH2PriorKnowledgeBenchmark.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "run". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GubvJdvnu9AEbvEH&open=AZy6GubvJdvnu9AEbvEH&pullRequest=6729

Check warning on line 101 in test/sdk-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apicall/httpclient/async/NettyHttpClientH2AlpnBenchmark.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "run". 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GuhyJdvnu9AEbvEJ&open=AZy6GuhyJdvnu9AEbvEJ&pullRequest=6729

Check warning on line 92 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "hasFailedWithThrowableThat"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Guk9Jdvnu9AEbvEf&open=AZy6Guk9Jdvnu9AEbvEf&pullRequest=6729

Check failure on line 82 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientBase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use try-with-resources or close this "TlsContextOptions" in a "finally" clause. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GuoMJdvnu9AEbvEt&open=AZy6GuoMJdvnu9AEbvEt&pullRequest=6729

Check warning on line 99 in test/sdk-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apicall/httpclient/async/NettyHttpClientH2PriorKnowledgeBenchmark.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "run" local variable. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GubvJdvnu9AEbvEI&open=AZy6GubvJdvnu9AEbvEI&pullRequest=6729

Check warning on line 65 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2ErrorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Gul8Jdvnu9AEbvEl&open=AZy6Gul8Jdvnu9AEbvEl&pullRequest=6729

Check warning on line 114 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2ErrorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Gul8Jdvnu9AEbvEk&open=AZy6Gul8Jdvnu9AEbvEk&pullRequest=6729

Check warning on line 46 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtAsyncHttpClientWireMockTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'software.amazon.awssdk.utils.AttributeMap'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GujXJdvnu9AEbvEV&open=AZy6GujXJdvnu9AEbvEV&pullRequest=6729

Check warning on line 141 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Guk9Jdvnu9AEbvEe&open=AZy6Guk9Jdvnu9AEbvEe&pullRequest=6729

Check warning on line 112 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Guk9Jdvnu9AEbvEc&open=AZy6Guk9Jdvnu9AEbvEc&pullRequest=6729

Check warning on line 46 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/CrtAsyncRequestExecutor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Catch Exception instead of Throwable. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GunPJdvnu9AEbvEr&open=AZy6GunPJdvnu9AEbvEr&pullRequest=6729

Check warning on line 73 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/CrtUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GunpJdvnu9AEbvEs&open=AZy6GunpJdvnu9AEbvEs&pullRequest=6729

Check warning on line 142 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtAsyncRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Guj4Jdvnu9AEbvEY&open=AZy6Guj4Jdvnu9AEbvEY&pullRequest=6729

Check warning on line 60 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Gui5Jdvnu9AEbvER&open=AZy6Gui5Jdvnu9AEbvER&pullRequest=6729

Check warning on line 27 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtAsyncHttpClientWireMockTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'software.amazon.awssdk.http.SdkHttpConfigurationOption.PROTOCOL'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GujXJdvnu9AEbvET&open=AZy6GujXJdvnu9AEbvET&pullRequest=6729

Check warning on line 85 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2ErrorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Gul8Jdvnu9AEbvEj&open=AZy6Gul8Jdvnu9AEbvEj&pullRequest=6729

Check warning on line 161 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtAsyncRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Guj4Jdvnu9AEbvEZ&open=AZy6Guj4Jdvnu9AEbvEZ&pullRequest=6729

Check warning on line 35 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtAsyncHttpClientSpiVerificationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.net.ConnectException'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GulsJdvnu9AEbvEg&open=AZy6GulsJdvnu9AEbvEg&pullRequest=6729

Check warning on line 101 in test/sdk-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apicall/httpclient/async/NettyHttpClientH2AlpnBenchmark.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "run" local variable. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GuhyJdvnu9AEbvEK&open=AZy6GuhyJdvnu9AEbvEK&pullRequest=6729

Check warning on line 78 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2ErrorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Gul8Jdvnu9AEbvEi&open=AZy6Gul8Jdvnu9AEbvEi&pullRequest=6729

Check warning on line 95 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/H2BehaviorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Gui5Jdvnu9AEbvEQ&open=AZy6Gui5Jdvnu9AEbvEQ&pullRequest=6729

Check warning on line 120 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientSpiVerificationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'executableRequest::call'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GumRJdvnu9AEbvEo&open=AZy6GumRJdvnu9AEbvEo&pullRequest=6729

Check warning on line 53 in http-clients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/internal/CrtUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZzA8uknZQt0JnA5SCzE&open=AZzA8uknZQt0JnA5SCzE&pullRequest=6729

Check warning on line 175 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/internal/CrtAsyncRequestExecutorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6Guj4Jdvnu9AEbvEa&open=AZy6Guj4Jdvnu9AEbvEa&pullRequest=6729

Check warning on line 40 in http-clients/aws-crt-client/src/test/java/software/amazon/awssdk/http/crt/AwsCrtAsyncHttpClientWireMockTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'software.amazon.awssdk.http.Protocol'. 

See more on https://sonarcloud.io/project/issues?id=aws_aws-sdk-java-v2&issues=AZy6GujXJdvnu9AEbvEU&open=AZy6GujXJdvnu9AEbvEU&pullRequest=6729
View more details on SonarQubeCloud