Skip to content

refactor: fix phpstan no type specified ValidationModelTest#10008

Merged
michalsn merged 5 commits intocodeigniter4:developfrom
adiprsa:fix/PHPSTAN-no-type-specified
Mar 2, 2026
Merged

refactor: fix phpstan no type specified ValidationModelTest#10008
michalsn merged 5 commits intocodeigniter4:developfrom
adiprsa:fix/PHPSTAN-no-type-specified

Conversation

@adiprsa
Copy link
Contributor

@adiprsa adiprsa commented Feb 27, 2026

Description
See #7731

  • Add PHPDoc type

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@mergeable
Copy link

mergeable bot commented Feb 27, 2026

Hi there, adiprsa! 👋

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work
on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Sincerely, the mergeable bot 🤖

@michalsn michalsn added the refactor Pull requests that refactor code label Feb 27, 2026
@adiprsa
Copy link
Contributor Author

adiprsa commented Feb 28, 2026

help, i made mistake commit without gpg
first without gpg, second amend with gpg, then appear pull merge branch
Screenshot from 2026-02-28 19-21-50

the commit log become mess

how i resolve this?

@paulbalandan
Copy link
Member

I do not see the merge commit here in GitHub.

@michalsn
Copy link
Member

@adiprsa See here: https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits

@adiprsa adiprsa force-pushed the fix/PHPSTAN-no-type-specified branch from 28a24b4 to ea64bf8 Compare March 1, 2026 10:54
@michalsn michalsn merged commit 68146b2 into codeigniter4:develop Mar 2, 2026
47 checks passed
@michalsn
Copy link
Member

michalsn commented Mar 2, 2026

Thank you @adiprsa

@adiprsa adiprsa deleted the fix/PHPSTAN-no-type-specified branch March 2, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants