Skip to content

refactor: fix phpstan no type specified ValidationModelTest #10008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalsn merged 5 commits into from
Mar 2, 2026
+5 −7
Merged

refactor: fix phpstan no type specified ValidationModelTest #10008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e94aa50
refactor: fix phpstan no type specified ValidationModelTest
adiprsa Feb 27, 2026
57b0ae4
Conform docblock style based on PHP 8.2 Lint
adiprsa Feb 27, 2026
33304bb
Apply suggestion from @neznaika0
adiprsa Feb 27, 2026
5c82b83
Remove trailing whitespace in comment
adiprsa Feb 27, 2026
ea64bf8
use PHPDOC array shape
adiprsa Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/system/Models/ValidationModelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ public function testValidationPassesWithMissingFields(): void
public function testValidationWithGroupName(): void
{
$config = new class () extends Validation {
/**
* @var array{'id': string, 'name': array{string, string}, 'token': string}
*/
public $grouptest = [
'id' => 'is_natural_no_zero',
'name' => [
Expand Down
2 changes: 1 addition & 1 deletion utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 2117 errors
# total 2116 errors

includes:
- argument.type.neon
Expand Down
7 changes: 1 addition & 6 deletions utils/phpstan-baseline/missingType.property.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 102 errors
# total 101 errors

parameters:
ignoreErrors:
Expand Down Expand Up @@ -506,8 +506,3 @@ parameters:
message: '#^Property CodeIgniter\\Entity\\Entity@anonymous/tests/system/Models/UpdateModelTest\.php\:401\:\:\$updated_at has no type specified\.$#'
count: 1
path: ../../tests/system/Models/UpdateModelTest.php

-
message: '#^Property Config\\Validation@anonymous/tests/system/Models/ValidationModelTest\.php\:245\:\:\$grouptest has no type specified\.$#'
count: 1
path: ../../tests/system/Models/ValidationModelTest.php
Loading