Update test to expect specific exception type for invalid private key#1
Merged
Update test to expect specific exception type for invalid private key#1
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refines the UtilsTest by updating the testGetNameIdDataWrongKey to expect a specific InvalidKeySpecRuntimeException instead of a generic Exception.
- Updates the expected exception type in the test.
- Improves the precision of the test to better reflect the actual error behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the UtilsTest class to refine the test testGetNameIdDataWrongKey. The expected exception type has been changed from a generic Exception to a specific InvalidKeySpecRuntimeException, improving the precision of the test and better reflecting the actual behavior of the method Util.loadPrivateKey.