Fix config sync server-side defaults when task field is empty#4526
Merged
ilyakuz-db merged 16 commits intomainfrom Feb 17, 2026
Merged
Fix config sync server-side defaults when task field is empty#4526ilyakuz-db merged 16 commits intomainfrom
task field is empty#4526ilyakuz-db merged 16 commits intomainfrom
Conversation
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 1b7faf5
34 interesting tests: 16 KNOWN, 8 RECOVERED, 6 flaky, 3 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
ilyakuz-db
commented
Feb 17, 2026
| if arr, ok := value.([]any); ok { | ||
| result := make([]any, 0, len(arr)) | ||
| for i, elem := range arr { | ||
| elementPath := fmt.Sprintf("%s[%d]", basePath, i) |
Contributor
Author
There was a problem hiding this comment.
I'll update basePath from string to PathNode in next PRs
denik
approved these changes
Feb 17, 2026
Contributor
Author
|
Integration test failures are not related, merging as is |
Collaborator
|
Commit: 5e4bc81
37 interesting tests: 16 KNOWN, 11 flaky, 6 RECOVERED, 3 FAIL, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Currently, we apply nested server-side defaults filtering only for sequences, but we need that for all nodes to also cover cases like creating new task when task array is not yet created for
Why
Unexpected no-op diff in config when running config-remote-sync
Tests
Added acceptance test