-
Notifications
You must be signed in to change notification settings - Fork 145
Fix config sync server-side defaults when task field is empty
#4526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
626d4bb
Restore empty lines in config-remote-sync
ilyakuz-db 410b7e3
Fix block scalars
ilyakuz-db d0ce021
Simplify and add unit tests
ilyakuz-db e39d467
Update test
ilyakuz-db 650b2b8
Simplify conditions, simplify regex
ilyakuz-db 10d8c89
Merge branch 'main' of github.com:databricks/cli into restore-empty-l…
ilyakuz-db a4ded2e
Update snapshots after merge
ilyakuz-db b993162
Fix duplicated blank lines near markers
ilyakuz-db e5bacc4
Simplify restoreBlankLines
ilyakuz-db 4dada1a
Safety net
ilyakuz-db 045de04
Move to separate function
ilyakuz-db 17afe1d
Merge branch 'main' of github.com:databricks/cli into restore-empty-l…
ilyakuz-db 3d0abd5
Capture test output
ilyakuz-db d1623b1
Apply filtering to all nodes
ilyakuz-db 6805e3d
Move helper
ilyakuz-db 1b7faf5
Merge branch 'main' of github.com:databricks/cli into fix-empty-task-…
ilyakuz-db File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update basePath from string to PathNode in next PRs