feat(storage): Restart delete resumable upload config by shubhangi-google · Pull Request #29215 · googleapis/google-cloud-ruby

shubhangi-google · 2025-02-27T09:57:24Z

Feature to support Restart and Delete resumable upload functionality

@example   

storage = Google::Cloud::Storage.new
bucket = storage.bucket bucket_name
## sample upload_id=  "AKDAyIs3wDvKFtl2e4PopZi-YtGZDxFr2vlR4Z58T6hL9Seypi5W2s7vrRe6-Qw5Fur79g11bT7MtcsSu-vYRkm5nVUKPpm_ciLPn65GQDqNMQ"
#Initiating Resumable upload 
bucket.create_file file, file_name
#Restarting  Resumable upload 
bucket.restart_resumable_upload file, upload_id
#Deleting Resumable upload 
bucket.delete_resumable_upload upload_id

Implementation linked with - googleapis/google-api-ruby-client#21896

bajajneha27 · 2025-03-06T06:40:56Z

#Initiating Resumable upload
bucket = storage.bucket bucket_name

How is this initiating the resumable upload?

#Restarting Resumable upload
storage = Google::Cloud::Storage.new(upload_chunk_size: chunk_size, upload_url: upload_url)

Again, how is this resuming the upload and why do I need to pass the upload_url in the client initialization ?

#Deleting Resumable upload
storage = Google::Cloud::Storage.new(upload_chunk_size: chunk_size, upload_url: upload_url, delete_upload: true)

I don't think we should be passing upload_url or delete_upload in the client initialization. They should rather be either separate functions or parameters for create_file or equivalent method of uploading an object/file.

google-cloud-storage/lib/google-cloud-storage.rb

bajajneha27 · 2025-03-06T06:46:45Z

Also, please disable the acceptance tests that are failing, create a separate bug to fix them and then enable them later.

shubhangi-google · 2025-03-13T10:20:42Z

Also, please disable the acceptance tests that are failing, create a separate bug to fix them and then enable them later.

Hi @bajajneha27 FYI samples are not always failing after @dazuma had merged some fixes in main branch

google-cloud-storage/lib/google/cloud/storage/bucket.rb

google-cloud-storage/test/google/cloud/storage/bucket_test.rb

google-cloud-storage/lib/google/cloud/storage/bucket.rb

bajajneha27

LGTM. Please look at the CI failure

google-cloud-storage/lib/google/cloud/storage/bucket.rb

shubhangi-google · 2025-05-26T18:01:35Z

@bajajneha27 Kokoro failure here is not related to changes made by us

Failure:
Google::Cloud::Storage::Bucket::uniform_bucket_level_access::storage#test_0002_sets uniform_bucket_level_access true and is unable to get the file [acceptance/storage/bucket_uniform_bucket_level_access_test.rb:68]:
Google::Cloud::PermissionDeniedError expected but nothing was raised.
https://btx.cloud.google.com/invocations/adb33245-6f5f-4ba0-b242-dacc2184369e/targets/cloud-devrel%2Fclient-libraries%2Fgoogle-cloud-ruby%2Fpresubmit%2Facceptance;config=default/log

bajajneha27 · 2025-06-03T06:16:50Z

google-cloud-storage/lib/google/cloud/storage/bucket.rb

+        def delete_resumable_upload upload_id
+          ensure_service!
+          raise "Upload Id missing" unless upload_id
+          service.delete_resumable_upload name, upload_id, options: { delete_upload: true }


I just thought of this.
Since the method already is separate for deleting the resumable upload, we don't need this option: delete_upload: true
We can just add it directly in core library method.

hi @bajajneha27 I have created a new PR #30510 as this PR seemed to have some issue after merging main branch

* docs: fix various typos in commentary PiperOrigin-RevId: 764977880 Source-Link: googleapis/googleapis@021fc2e Source-Link: googleapis/googleapis-gen@9fb7f64 Copy-Tag: eyJwIjoiZ29vZ2xlLWNsb3VkLXBhcmFsbGVsc3RvcmUtdjFiZXRhLy5Pd2xCb3QueWFtbCIsImgiOiI5ZmI3ZjY0ZjgxNjg2YzY3MmNmNzNiOTJiZDU0MjYzYzk1NTljZTE4In0= * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…leapis#30484)

…er Admin Instances API (googleapis#30480)

…0482) feat: add a project ID to table reference so that org parents can create single table discovery configs. feat: new fields for data profile finding. docs: various doc revisions

feat: add image_gc_low_threshold_percent in NodeKubeletConfig feat: add image_gc_high_threshold_percent in NodeKubeletConfig feat: add image_minimum_gc_age in NodeKubeletConfig feat: add image_maximum_gc_age in NodeKubeletConfig feat: add container_log_max_size in NodeKubeletConfig feat: add container_log_max_files in NodeKubeletConfig feat: add allowed_unsafe_sysctls in NodeKubeletConfig feat: add TopologyManager feat: add MemoryManager feat: add storage_pools in NodeConfig feat: add max_run_duration in NodeConfig feat: add local_ssd_encryption_mode in NodeConfig feat: add effective_cgroup_mode in NodeConfig feat: add flex_start in NodeConfig feat: add performance_monitoring_unit in AdvancedMachineFeatures feat: add parallelstore_csi_driver_config in AddonsConfig feat: add high_scale_checkpointing_config in AddonsConfig feat: add private_endpoint_enforcement_enabled in MasterAuthorizedNetworksConfig feat: add alpha_cluster_feature_gates in Cluster feat: add pod_autoscaling in Cluster feat: add control_plane_endpoints_config in Cluster feat: add user_managed_keys_config in Cluster feat: add rbac_binding_config in Cluster feat: add anonymous_authentication_config in Cluster feat: add linux_node_config in NodePoolAutoConfig feat: add desired_default_enable_private_nodes in ClusterUpdate feat: add desired_control_plane_endpoints_config in ClusterUpdate feat: add desired_pod_autoscaling in ClusterUpdate feat: add user_managed_keys_config in ClusterUpdate feat: add desired_rbac_binding_config in ClusterUpdate feat: add desired_enterprise_config in ClusterUpdate feat: add desired_disable_l4_lb_firewall_reconciliation in ClusterUpdate feat: add desired_node_pool_auto_config_linux_node_config in ClusterUpdate feat: add desired_compliance_posture_config in ClusterUpdate feat: add desired_anonymous_authentication_config in ClusterUpdate feat: add storage_pools in UpdateNodePoolRequest feat: add max_run_duration in UpdateNodePoolRequest feat: add flex_start in UpdateNodePoolRequest feat: add upgrade_target_version in ReleaseChannelConfig feat: add NODE_SERVICE_ACCOUNT_MISSING_PERMISSIONS in StatusCondition.Code feat: add disable_l4_lb_firewall_reconciliation in NetworkConfig feat: add UPGRADE_INFO_EVENT in NotificationConfig.EventType feat: add confidential_instance_type in ConfidentialNodes feat: add event_type in UpgradeInfoEvent feat: add standard_support_end_time in UpgradeInfoEvent feat: add extended_support_end_time in UpgradeInfoEvent feat: add mitigated_versions in SecurityBulletinEvent feat: add autopilot_compatibility_auditing_enabled in WorkloadPolicyConfig feat: add KCP_HPA in LoggingComponentConfig.Component feat: add JOBSET in MonitoringComponentConfig.Component feat: add auto_monitoring_config in ManagedPrometheusConfig feat: add data_cache_count in EphemeralStorageLocalSsdConfig feat: add FetchClusterUpgradeInfoRequest feat: add ClusterUpgradeInfo feat: add UpgradeDetails feat: add FetchNodePoolUpgradeInfoRequest feat: add NodePoolUpgradeInfo docs: Minor documentation updates

feat: add image_gc_low_threshold_percent in NodeKubeletConfig feat: add image_gc_high_threshold_percent in NodeKubeletConfig feat: add image_minimum_gc_age in NodeKubeletConfig feat: add image_maximum_gc_age in NodeKubeletConfig feat: add container_log_max_size in NodeKubeletConfig feat: add container_log_max_files in NodeKubeletConfig feat: add allowed_unsafe_sysctls in NodeKubeletConfig feat: add max_run_duration in NodeConfig feat: add flex_start in NodeConfig feat: add performance_monitoring_unit in AdvancedMachineFeatures feat: add high_scale_checkpointing_config in AddonsConfig feat: add alpha_cluster_feature_gates in Cluster feat: add pod_autoscaling in Cluster feat: add desired_pod_autoscaling in ClusterUpdate feat: add desired_disable_l4_lb_firewall_reconciliation in ClusterUpdate feat: add desired_anonymous_authentication_config in ClusterUpdate feat: add max_run_duration in UpdateNodePoolRequest feat: add flex_start in UpdateNodePoolRequest feat: add NODE_SERVICE_ACCOUNT_MISSING_PERMISSIONS in StatusCondition.Code feat: add disable_l4_lb_firewall_reconciliation in NetworkConfig feat: add UPGRADE_INFO_EVENT in NotificationConfig.EventType feat: add confidential_instance_type in ConfidentialNodes feat: add event_type in UpgradeInfoEvent feat: add standard_support_end_time in UpgradeInfoEvent feat: add extended_support_end_time in UpgradeInfoEvent feat: add mitigated_versions in SecurityBulletinEvent feat: add autopilot_compatibility_auditing_enabled in WorkloadPolicyConfig feat: add KCP_HPA in LoggingComponentConfig.Component feat: add JOBSET in MonitoringComponentConfig.Component feat: add auto_monitoring_config in ManagedPrometheusConfig feat: add data_cache_count in EphemeralStorageLocalSsdConfig feat: add FetchClusterUpgradeInfoRequest feat: add ClusterUpgradeInfo feat: add UpgradeDetails feat: add FetchNodePoolUpgradeInfoRequest feat: add NodePoolUpgradeInfo docs: Minor documentation updates

…s#30489)

…pis#30487)

…ogleapis#30463)

feat: add identity mapping service feat: add user license config service feat: add HealthcareFhirConfig to FHIR data store feat: add ConnectorRunErrorContext to error log feat: support structured content for chunk feat: support ACL data store and document feat: add more options for layout parser config feat: support media recommendation engine feat: enable claim level score for grounding feat: add custom search operators for Workspace search feat: add more indexing state for site search engine docs: keep the API doc up-to-date with recent changes

shubhangi-google marked this pull request as ready for review March 3, 2025 11:01

shubhangi-google requested review from a team and yoshi-approver as code owners March 3, 2025 11:01

shubhangi-google mentioned this pull request Mar 3, 2025

feat(storage): Restart & delete resumable upload googleapis/google-api-ruby-client#21896

Merged

bajajneha27 requested changes Mar 6, 2025

View reviewed changes

google-cloud-storage/lib/google-cloud-storage.rb Outdated Show resolved Hide resolved

shubhangi-google marked this pull request as draft March 10, 2025 05:23

shubhangi-google marked this pull request as ready for review March 13, 2025 10:24

shubhangi-google requested a review from a team as a code owner March 13, 2025 10:24

shubhangi-google requested a review from bajajneha27 March 13, 2025 10:24

bajajneha27 requested changes Mar 17, 2025

View reviewed changes

google-cloud-storage/lib/google/cloud/storage/bucket.rb Outdated Show resolved Hide resolved

google-cloud-storage/test/google/cloud/storage/bucket_test.rb Outdated Show resolved Hide resolved

shubhangi-google marked this pull request as draft April 30, 2025 10:25

shubhangi-google requested a review from bajajneha27 May 2, 2025 09:23

shubhangi-google marked this pull request as ready for review May 2, 2025 09:23

bajajneha27 requested changes May 2, 2025

View reviewed changes

google-cloud-storage/lib/google/cloud/storage/bucket.rb Outdated Show resolved Hide resolved

shubhangi-google requested a review from bajajneha27 May 7, 2025 05:54

bajajneha27 reviewed May 8, 2025

View reviewed changes

google-cloud-storage/lib/google/cloud/storage/bucket.rb Outdated Show resolved Hide resolved

bajajneha27 reviewed Jun 3, 2025

View reviewed changes

release-please bot added 8 commits June 11, 2025 20:28

chore(main): release google-cloud-functions-v2 1.1.0 (googleapis#30190)

3fa291c

chore(main): release google-cloud-functions-v1 2.1.0 (googleapis#30189)

1d9fbca

chore(main): release google-cloud-firestore-v1 2.1.0 (googleapis#30188)

bdedec7

chore(main): release google-cloud-firestore-admin-v1 1.5.0 (googleapi…

58a2bee

…s#30187)

chore(main): release google-cloud-financial_services-v1 0.2.0 (google…

ea8953c

…apis#30186)

chore(main): release google-cloud-filestore-v1 2.2.0 (googleapis#30185)

6e083c5

chore(main): release google-cloud-eventarc-v1 2.1.0 (googleapis#30184)

5815149

chore(main): release google-cloud-eventarc-publishing-v1 1.4.0 (googl…

2066d8f

…eapis#30183)

release-please bot and others added 24 commits June 11, 2025 20:29

chore(main): release google-cloud-bigquery-data_transfer 1.7.2 (googl…

af04d58

…eapis#30446)

chore(main): release google-cloud-managed_kafka-v1 1.3.0 (googleapis#…

1e06d32

…30454)

chore(main): release google-cloud-language 2.0.2 (googleapis#30453)

21c189d

chore(main): release google-cloud-kms 2.9.2 (googleapis#30452)

d172eaf

chore(main): release google-cloud-dialogflow 1.11.2 (googleapis#30450)

4ab6f09

chore(main): release google-cloud-container_analysis 1.5.2 (googleapi…

590eddd

…s#30448)

feat: update routing headers to new format (googleapis#30481)

7817254

feat: add AggregateQuery explanation features for RubyFirestore (goog…

7f33d79

…leapis#30484)

build: ensure there's only a single service config file for the Spann…

07c45a0

…er Admin Instances API (googleapis#30480)

docs: Add clarifications on IAP CorsSettings behavior (googleapis#30483)

2080b33

feat: add Dataplex Catalog action for discovery configs (googleapis#3…

9de3554

…0482) feat: add a project ID to table reference so that org parents can create single table discovery configs. feat: new fields for data profile finding. docs: various doc revisions

chore(main): release google-cloud-iap-v1 1.4.1 (googleapis#30492)

1ac7167

chore(main): release google-cloud-dlp-v2 1.11.0 (googleapis#30490)

37306d8

chore(main): release google-cloud-container-v1beta1 0.47.0 (googleapi…

3fba8ca

…s#30489)

chore(main): release google-cloud-parallelstore-v1beta 0.9.1 (googlea…

0ba763e

…pis#30487)

chore(main): release google-cloud-container-v1 1.8.0 (googleapis#30488)

b62abc2

chore(main): release google-cloud-spanner-admin-database-v1 1.8.0 (go…

8a626b9

…ogleapis#30463)

feat(spanner): add new change_stream.proto (googleapis#30493)

5695d64

Merge branch 'main' into restart_delete_resumable_upload

5f3a440

shubhangi-google marked this pull request as draft June 12, 2025 06:56

This was referenced Jun 13, 2025

chor(storage): Restart & delete resumable upload part 2 googleapis/google-api-ruby-client#23376

Merged

feat(storage): Restart delete resumable upload config new #30510

Closed

Update bucket.rb

ae829a3

shubhangi-google closed this Jul 9, 2025

shubhangi-google mentioned this pull request Aug 25, 2025

feat(storage): Restart delete resumable upload config new #30882

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(storage): Restart delete resumable upload config#29215

feat(storage): Restart delete resumable upload config#29215
shubhangi-google wants to merge 2264 commits intogoogleapis:mainfrom
shubhangi-google:restart_delete_resumable_upload

shubhangi-google commented Feb 27, 2025 •

edited

Loading

Uh oh!

bajajneha27 commented Mar 6, 2025

Uh oh!

Uh oh!

bajajneha27 commented Mar 6, 2025

Uh oh!

shubhangi-google commented Mar 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bajajneha27 left a comment

Uh oh!

Uh oh!

shubhangi-google commented May 26, 2025

Uh oh!

bajajneha27 Jun 3, 2025

Uh oh!

shubhangi-google Jun 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

shubhangi-google commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bajajneha27 commented Mar 6, 2025

Uh oh!

Uh oh!

bajajneha27 commented Mar 6, 2025

Uh oh!

shubhangi-google commented Mar 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bajajneha27 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shubhangi-google commented May 26, 2025

Uh oh!

bajajneha27 Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

shubhangi-google Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shubhangi-google commented Feb 27, 2025 •

edited

Loading