fix: Allow modifying fdv2 data source options independent of main config#403
Merged
fix: Allow modifying fdv2 data source options independent of main config#403
Conversation
| config.http, | ||
| config.initial_reconnect_delay, | ||
| config | ||
| ) |
There was a problem hiding this comment.
Test helper incorrectly appends endpoint to base URI
Low Severity
The test helper make_streaming_data_source() incorrectly passes config.stream_base_uri + STREAMING_ENDPOINT to StreamingDataSource, but the constructor expects just the base URI without the endpoint. The create_sse_client function adds STREAMING_ENDPOINT to the URI it receives, so this would result in a doubled endpoint (e.g., /sdk/stream/sdk/stream). Tests pass because they mock _sse_client_builder, but the helper function is constructing the object incorrectly.
jsonbailey
approved these changes
Feb 3, 2026
Contributor
jsonbailey
left a comment
There was a problem hiding this comment.
There is one cursor comment in the test_streaming_synchronizer that you should double check but everything else looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Touches core FDv2 synchronization and HTTP wiring; misconfigured defaults or builder overrides could change network behavior (URIs/timeouts) or break initialization if
.build()paths are missed.Overview
Refactors FDv2
DataSystemConfigto use a newDataSourceBuilderprotocol (objects withbuild(config)) instead ofCallable[[Config], T]factories, and updates FDv2 (fdv2.py) to call.build()for initializers/synchronizers.Updates polling and streaming FDv2 data sources to accept per-source overrides (base URI, poll interval / reconnect delay, and
HTTPConfig) via new builder classes; requesters now build their ownHTTPFactoryfrom_base_headers(config)and the builder-suppliedHTTPConfig/URI rather than always usingconfig.http/config.base_uri.Adds builder implementations for FileDataV2 and TestDataV2, updates integrations/tests/contract tests to use the new builder API, and adjusts
StreamingDataSource/SSE client builder signatures accordingly.Written by Cursor Bugbot for commit 451ff2d. This will update automatically on new commits. Configure here.