fix(wall-tool): snap length to grid instead of absolute coords to fix 90° gap at off-grid points#261
Open
zephran-dev wants to merge 1 commit intopascalorg:mainfrom
Open
fix(wall-tool): snap length to grid instead of absolute coords to fix 90° gap at off-grid points#261zephran-dev wants to merge 1 commit intopascalorg:mainfrom
zephran-dev wants to merge 1 commit intopascalorg:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When starting a wall from an off-grid endpoint (e.g. 17ft = 5.18m), the
angle snap would correctly lock the direction to 90°, but then
snapPointToGridwould round the absolute X/Z coordinates — moving theendpoint away from the true perpendicular and creating micro-gaps in
closed rooms.
Root Cause
In
snapPointTo45Degrees, after snapping the angle the result was passedthrough
snapPointToGrid, which rounds world-space coordinates to theglobal grid regardless of where the start point is.
Fix
Instead of snapping the final XZ position to the grid, snap only the
distance (scalar) to the grid step. The direction stays locked to the
snapped angle and the start point is preserved exactly.
Closes #256