Skip to content

fix(wall-tool): snap length to grid instead of absolute coords to fix 90° gap at off-grid points #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zephran-dev wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

fix(wall-tool): snap length to grid instead of absolute coords to fix 90° gap at off-grid points #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/editor/src/components/tools/wall/wall-drafting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,15 @@ export function snapPointTo45Degrees(
const snappedAngle = Math.round(angle / angleStep) * angleStep
const distance = Math.sqrt(dx * dx + dz * dz)

return snapPointToGrid([
start[0] + Math.cos(snappedAngle) * distance,
start[1] + Math.sin(snappedAngle) * distance,
], step)
// Snap do comprimento ao grid step (não das coordenadas absolutas)
// Isso preserva o start exato e garante que a parede perpendicular
// comece e termine no ponto certo, sem micro-gaps
const snappedDistance = Math.round(distance / step) * step

return [
start[0] + Math.cos(snappedAngle) * snappedDistance,
start[1] + Math.sin(snappedAngle) * snappedDistance,
]
}

export function getWallAngleSnapStep(step = getWallGridStep()): number {
Expand Down