gh-143511: Document sys.remote_exec permissions requirements #143575
Conversation
|
Wouldn't it make more sense to add this info to the remote debugging docs? 🤔 |
|
@RafaelWO Well i figured sys.rst or sys.executable here is way more used or gone through by users on a daily basis? Sys.rst is more discoverable for users hitting the error. |
StanFromIreland
changed the title
Doc/library/sys.rst
Outdated
| Callers should adjust permissions before calling, for example:: | ||
|
|
||
| import os | ||
| import tempfile | ||
| import sys | ||
|
|
||
| with tempfile.NamedTemporaryFile(mode='w', suffix='.py', delete=False) as f: | ||
| f.write("print('Hello from remote!')") | ||
| f.flush() | ||
| os.chmod(f.name, 0o644) # Readable by group/other | ||
| sys.remote_exec(pid, f.name) | ||
| os.unlink(f.name) # Cleanup |
There was a problem hiding this comment.
This should be put before the audit event descriptions.
There was a problem hiding this comment.
It's not before the audit events yet. Speaking in line numbers, your paragraph should be after line 1998 but before 2000.
There was a problem hiding this comment.
Did so
accidentally named the commit the same as last one but yeah, shouldn't be a problem
There was a problem hiding this comment.
You are almost there: Please move all your content above the audit-event directives - not just the first paragraph 😉
|
You need to update your branch to fix the CI. |
|
@StanFromIreland Are there any more changes I need to apply |
|
You need to resolve the conflicts first |
|
@picnixz I've resolved it |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
|
When tests fail, please do not request a review. |
| and minor version as the local process. If either the local or remote | ||
| interpreter is pre-release (alpha, beta, or release candidate) then the | ||
| local and remote interpreters must be the same exact version. | ||
| local and remote interpreters must be the same exact version. |
There was a problem hiding this comment.
| local and remote interpreters must be the same exact version. | |
| local and remote interpreters must be the same exact version. |
4 participants
sys.remote_exec(pid, script_path)creates a temporary script with restrictivepermissions (typically
0o600). The target process must be able to read thisfile, which fails in cross-user scenarios (e.g. sudo debugging).
Added documentation note with example showing how to
os.chmod()the file to0o644(readable by group/other) before calling.Addresses the PermissionError reported in #143511.
Co-authored-by: @RafaelWO
📚 Documentation preview 📚: https://cpython-previews--143575.org.readthedocs.build/