-
-
Notifications
You must be signed in to change notification settings - Fork 34k
gh-143511: Document sys.remote_exec permissions requirements #143575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yashp002
wants to merge
15
commits into
python:main
Choose a base branch
from
Yashp002:gh-143511-remote-exec-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−0
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
91c984c
execdocs first commit
Yashp002 d1256a4
remotexec fix 1
Yashp002 c96d1aa
remotexec fix 2
Yashp002 9f6d131
remotexec fix 3
Yashp002 fe77ba9
remotexec fix 3
Yashp002 6687123
remotexec fix 4
Yashp002 9d3be80
Retriggering checks
Yashp002 9290444
Merge branch 'main' into gh-143511-remote-exec-docs
StanFromIreland 17d72e6
Merge branch 'main' into gh-143511-remote-exec-docs
Yashp002 a92496d
Update Doc/library/sys.rst
Yashp002 eacadb1
Update Doc/library/sys.rst
Yashp002 92fc961
Update Doc/library/sys.rst
Yashp002 809133b
Update Doc/library/sys.rst
Yashp002 fd20f01
Update Doc/library/sys.rst
Yashp002 269d9ff
remotexec fix 5
Yashp002 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I am sorry about this suggestion. I thought it would have been enough but I think we need to do revert to your original suggestion with os.unlink(). However, we may need a try-finally + catch OSError for the unlink failure:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that sometimes on Windows we have issues with automatic deletion. But altenratively, we could just have a context manager and keep the defaults: