Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThis pull request adds a deprecation notice for the thirdweb Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/thirdweb/src/cli/bin.ts (1)
51-52: Remove unreachablebreakafterprocess.exit(1).Line 52 is dead code because Line 51 exits the process.
Proposed cleanup
process.exit(1); - break;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/thirdweb/src/cli/bin.ts` around lines 51 - 52, Remove the unreachable statement following process.exit(1) by deleting the redundant break; that follows the process.exit(1) call (the break after process.exit(1) within the same switch/case or control block is dead code and should be removed so only process.exit(1) remains).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/thirdweb/src/cli/bin.ts`:
- Around line 51-52: Remove the unreachable statement following process.exit(1)
by deleting the redundant break; that follows the process.exit(1) call (the
break after process.exit(1) within the same switch/case or control block is dead
code and should be removed so only process.exit(1) remains).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 28ba6b53-7ea8-429a-a5fe-ba3786a78bbc
📒 Files selected for processing (2)
.changeset/deprecate-create-command.mdpackages/thirdweb/src/cli/bin.ts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8700 +/- ##
=======================================
Coverage 52.73% 52.73%
=======================================
Files 934 934
Lines 62968 62968
Branches 4138 4135 -3
=======================================
Hits 33204 33204
Misses 29666 29666
Partials 98 98
🚀 New features to boost your workflow:
|
size-limit report 📦
|
PR-Codex overview
This PR focuses on deprecating the
thirdweb createCLI command, advising users to switch to thethirdwebdashboard instead.Detailed summary
thirdweb createcommand inpackages/thirdweb/src/cli/bin.ts.thirdweb dashboardat the provided URL.createcommand is invoked.Summary by CodeRabbit
thirdweb createCLI command has been deprecated and will display a deprecation message when invoked.